Add rotation prop#464
Closed
bluematter wants to merge 7 commits intoreact-grid-layout:masterfrom
bluematter:master
Closed
Add rotation prop#464bluematter wants to merge 7 commits intoreact-grid-layout:masterfrom bluematter:master
bluematter wants to merge 7 commits intoreact-grid-layout:masterfrom
bluematter:master
Conversation
Collaborator
|
Hi. I don't know what this really does, do you have a demo? Please don't also adjust the whole project's styling in a PR. Your preferences are not the project's preferences and it obfuscates what you are actually changing. Additionally it is not possible to accept a PR that has a version bump in it. |
Collaborator
|
Going to close this as a dupe of #387 until there's a more clear PR & justification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding rotation to objects in https://storycreatorapp.com/ and think it would be nice to have the ability to pass in rotation to the component.
It can be a pain placing the rotation in the parent component. Passing it through directly works quite well for my needs and I assume other folks needs.